Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Governor module connecting with AccessManager #4523

Merged
merged 36 commits into from
Aug 16, 2023
Merged

Add Governor module connecting with AccessManager #4523

merged 36 commits into from
Aug 16, 2023

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Aug 10, 2023

This module allows a Governor instance to use contracts restricted by an AccessManager.

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b37ed30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ernestognw
ernestognw reviewed Aug 10, 2023
View reviewed changes
contracts/governance/extensions/GovernorTimelockAccess.sol Outdated Show resolved Hide resolved
contracts/governance/extensions/GovernorTimelockAccess.sol Show resolved Hide resolved
contracts/governance/extensions/GovernorTimelockAccess.sol Outdated Show resolved Hide resolved
contracts/governance/extensions/GovernorTimelockAccess.sol Outdated Show resolved Hide resolved
contracts/governance/extensions/GovernorTimelockAccess.sol Outdated Show resolved Hide resolved
contracts/governance/extensions/GovernorTimelockAccess.sol Outdated Show resolved Hide resolved
contracts/governance/extensions/GovernorTimelockAccess.sol Outdated Show resolved Hide resolved
contracts/governance/extensions/GovernorTimelockAccess.sol Outdated Show resolved Hide resolved
contracts/governance/extensions/GovernorTimelockAccess.sol Outdated Show resolved Hide resolved
contracts/governance/extensions/GovernorTimelockAccess.sol Outdated Show resolved Hide resolved
ernestognw
ernestognw reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. Of course we still need tests and some docs but I think it's ready solidity-wise

contracts/governance/extensions/GovernorTimelockAccess.sol Outdated Show resolved Hide resolved
contracts/governance/extensions/GovernorTimelockAccess.sol Show resolved Hide resolved
frangio and others added 2 commits August 15, 2023 18:03
@frangio
add tests for proposalNeedsQueuing
a1cbc83
@frangio @ernestognw
Apply suggestions from code review
ebd6dcd 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
This was referenced Sep 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@RomulousApollo RomulousApollo mentioned this pull request Sep 12, 2024
Open
This was referenced Sep 12, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frangio @ernestognw